chore(launchpad): add app_name field to preprod artifact table #95383
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Add field app_name to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "app_name" varchar(255) NULL; |
noahsmartin
reviewed
Jul 15, 2025
| @@ -116,6 +116,9 @@ def as_choices(cls): | |||
| # Installable file like IPA or APK | |||
| installable_app_file_id = BoundedBigIntegerField(db_index=True, null=True) | |||
|
|
|||
| # The name of the app, e.g. "My App" | |||
| app_name = models.CharField(max_length=255, null=True) | |||
There was a problem hiding this comment.
I think we also need the app_id right?
noahsmartin
approved these changes
Jul 15, 2025
NicoHinderling
force-pushed
the
add-app-name-field-preprod-table
branch
from
f587973 to
a7b9dfd
Compare
|
This PR has a migration; here is the generated SQL for for --
-- Add field app_id to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "app_id" varchar(255) NULL;
--
-- Add field app_name to preprodartifact
--
ALTER TABLE "sentry_preprodartifact" ADD COLUMN "app_name" varchar(255) NULL; |
NicoHinderling
force-pushed
the
add-app-name-field-preprod-table
branch
from
a7b9dfd to
8bceb7d
Compare
wedamija
approved these changes
Jul 15, 2025
NicoHinderling
added a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/getsentry/launchpad/blob/main/src/launchpad/size/models/common.py#L19
allows us to store the name of the app from the information we extract